Discussion:
[SSSD] [sssd PR#5537][opened] negcache: use right domain in nss_protocol_fill_initgr()
sumit-bose
2021-03-15 17:22:02 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: opened

PR body:
"""
When checking if a group returned by an initgroups request is filtered
in the negative cache the domain of the user was used. This does not
work reliable if the user can be a member of groups from multiple
domains.

With this patch th domain the group belongs to is determined and used
while checking the negative cache.

Resolves: https://github.com/SSSD/sssd/issues/5534
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537
sumit-bose
2021-03-29 15:56:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Waiting for review
sumit-bose
2021-03-29 15:56:46 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Changes requested
sumit-bose
2021-03-29 15:56:24 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
Hi,

thanks for the review. I tired to use a single return but I agree that with your suggestions to code is more readable. New version contains the fixes.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-809496754
pbrezina
2021-03-29 12:51:23 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Changes requested
sumit-bose
2021-03-29 15:23:39 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537
alexey-tikhonov
2021-04-01 09:36:22 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

alexey-tikhonov commented:
"""
Shall this target 1-16 as well? (https://bugzilla.redhat.com/show_bug.cgi?id=1945552)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-811785975
pbrezina
2021-04-01 10:45:59 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Ack to the code but there is conflict. Can you please rebase it?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-811823186
sumit-bose
2021-04-06 08:43:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537
sumit-bose
2021-04-06 08:44:14 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
Post by alexey-tikhonov
Shall this target 1-16 as well? (https://bugzilla.redhat.com/show_bug.cgi?id=1945552)
yes
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-813945305
sumit-bose
2021-04-06 08:44:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
Post by pbrezina
Ack to the code but there is conflict. Can you please rebase it?
done
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-813945541
alexey-tikhonov
2021-04-06 08:46:31 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +branch: sssd-1-16
alexey-tikhonov
2021-04-06 08:46:44 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Bugzilla
pbrezina
2021-04-13 11:40:50 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818669134
pbrezina
2021-04-13 11:40:55 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Waiting for review
pbrezina
2021-04-13 11:40:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Accepted
pbrezina
2021-04-13 11:45:18 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Ready to push
pbrezina
2021-04-13 11:47:31 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Ready to push
pbrezina
2021-04-13 11:48:25 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -branch: sssd-1-16
pbrezina
2021-04-13 11:48:35 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
1.16 did not apply, please open separate PR
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818673129
pbrezina
2021-04-13 11:48:47 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Ready to push
pbrezina
2021-04-13 11:49:06 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5537

* `master`
* 231d1118727b989a4af9911a45a465912fe659d6 - negcache: use right domain in nss_protocol_fill_initgr()

"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818673390
pbrezina
2021-04-13 11:49:09 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Pushed
pbrezina
2021-04-13 11:49:12 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Accepted
pbrezina
2021-04-13 11:49:14 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Ready to push
pbrezina
2021-04-13 11:49:17 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537

Loading...