Discussion:
[SSSD] [sssd PR#5573][opened] configure: set CPP macro with AC_PROG_CPP
ikerexxe
2021-04-07 15:30:17 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Author: ikerexxe
Title: #5573: configure: set CPP macro with AC_PROG_CPP
Action: opened

PR body:
"""
sssd build with an autoconf version greater than 2.70 fails because CPP
macro is empty. This change fixes this problem by setting the macro with
AC_PROG_CPP at the beginning of the configuration.

Resolves: https://github.com/SSSD/sssd/issues/5563
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5573/head:pr5573
git checkout pr5573
kloczek
2021-04-07 16:49:21 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

kloczek commented:
"""
I can confirm that thi patch fixes buils fter "autoreconf -fiv" with ac 2.71 in build env.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5573#issuecomment-815066137
sumit-bose
2021-04-08 06:02:18 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

sumit-bose commented:
"""
Hi,

thanks, ACK.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5573#issuecomment-815473258
sumit-bose
2021-04-08 06:02:26 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

Label: +Accepted
pbrezina
2021-04-08 09:15:20 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

Label: +Ready to push
pbrezina
2021-04-08 09:17:10 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5573

* `master`
* 49010b16ed90eb743dc7c47d2ba7b6ae84c049cd - configure: set CPP macro with AC_PROG_CPP

"""

See the full comment at https://github.com/SSSD/sssd/pull/5573#issuecomment-815599407
pbrezina
2021-04-08 09:17:12 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

Label: +Pushed
pbrezina
2021-04-08 09:17:15 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

Label: -Accepted
pbrezina
2021-04-08 09:17:19 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Title: #5573: configure: set CPP macro with AC_PROG_CPP

Label: -Ready to push
pbrezina
2021-04-08 09:17:22 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5573
Author: ikerexxe
Title: #5573: configure: set CPP macro with AC_PROG_CPP
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5573/head:pr5573
git checkout pr5573

Loading...