Discussion:
[SSSD] [sssd PR#5641][opened] UTIL/SECRETS: mistype fix
alexey-tikhonov
2021-05-18 11:28:52 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Author: alexey-tikhonov
Title: #5641: UTIL/SECRETS: mistype fix
Action: opened

PR body:
"""
Wrong variable was tested after mem allocation.

Also fixes following covscan issues:
```
Error: DEADCODE (CWE-561):
sssd-2.5.0/src/util/secrets/secrets.c:1004: cond_notnull: Condition "uuid_list == NULL", taking false branch. Now the value of "uuid_list" is not "NULL".
sssd-2.5.0/src/util/secrets/secrets.c:1010: notnull: At condition "uuid_list == NULL", the value of "uuid_list" cannot be "NULL".
sssd-2.5.0/src/util/secrets/secrets.c:1010: dead_error_condition: The condition "uuid_list == NULL" cannot be true.
sssd-2.5.0/src/util/secrets/secrets.c:1011: dead_error_begin: Execution cannot reach this statement: "ret = 12;".
# 1009| uid_list = talloc_zero_array(tmp_ctx, const char *, res->count);
# 1010| if (uuid_list == NULL) {
# 1011|-> ret = ENOMEM;
# 1012| goto done;
# 1013| }
```
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5641/head:pr5641
git checkout pr5641
alexey-tikhonov
2021-05-18 11:29:52 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: +Waiting for review
justin-stephenson
2021-05-18 12:32:21 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: +Accepted
justin-stephenson
2021-05-18 12:32:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: -Waiting for review
justin-stephenson
2021-05-18 12:32:31 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

justin-stephenson commented:
"""
Ack, thank you.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5641#issuecomment-843131647
pbrezina
2021-05-19 17:23:13 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: +Ready to push
pbrezina
2021-05-19 17:24:39 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5641

* `master`
* 9777427facccbbe45c855b0319258335dffb986a - UTIL/SECRETS: mistype fix

"""

See the full comment at https://github.com/SSSD/sssd/pull/5641#issuecomment-844312213
pbrezina
2021-05-19 17:24:42 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: +Pushed
pbrezina
2021-05-19 17:24:43 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: -Accepted
pbrezina
2021-05-19 17:24:46 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Title: #5641: UTIL/SECRETS: mistype fix

Label: -Ready to push
pbrezina
2021-05-19 17:24:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5641
Author: alexey-tikhonov
Title: #5641: UTIL/SECRETS: mistype fix
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5641/head:pr5641
git checkout pr5641

Loading...