[SSSD] [sssd PR#5610][opened] sudo improvements

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: opened

PR body:
"""
Resolves:
* https://github.com/SSSD/sssd/issues/5601
* https://github.com/SSSD/sssd/issues/5603
* https://github.com/SSSD/sssd/issues/5604
* https://github.com/SSSD/sssd/issues/5609
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

pbrezina commented:
"""
The tests fails because ldap_sudo_random_offset default to 30 instead of 0. I wonder if I should update the tests or change the default value to 0?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-829105358

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: +Waiting for review

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

pbrezina commented:
"""
@sgoveas Hi, this adds new option `ldap_sudo_random_offset` that defaults to 30 seconds. This will make some sudo tests fail (those that test smart and full refresh at the very least). I didn't find relevant multihost test so I assume sudo is still tested by bash tests and those needs to be amended.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-830014705

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

pbrezina commented:
"""
@sgoveas Hi, this adds new option `ldap_sudo_random_offset` that defaults to 30 seconds. This will make some sudo tests fail (those that test smart and full refresh at the very least). I didn't find relevant multihost test so I assume sudo is still tested by bash tests and those needs to be amended with `ldap_sudo_random_offset = 0`.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-830014705

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610

[thalman]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

thalman commented:
"""
The code looks good, works for me. I have just one comment: You titled one commit "be: add be_ptask_reschedule" but the function added is called *_postpone. Could you make that consistent for future search/reference?

Tom
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-834259651

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

pbrezina commented:
"""
Done
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-834261367

[thalman]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

thalman commented:
"""
Thank you for the update,
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-834262363

[thalman]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: +Accepted

[thalman]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: -Waiting for review

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: +Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5610

* `master`
* ca47accad0b8e1dccf0618df7ce8352ccdbd4dea - sudo: add ldap_sudo_random_offset
* d9d5c291fe68003c31061cfb7d32676c98726560 - sudo: reschedule periodic tasks when full refresh is finished
* c0204c063cef32999db996b21dd7bda401643c57 - be: add be_ptask_postpone
* b3247eeb562bf92ea7f0938eda6d0203e7cb63c4 - man: document how to tune sudo performance
* 61a03b2ccebce2116b36f3e4b424d7dfe6436ce4 - man: document how to disable sudo smart and full refresh

"""

See the full comment at https://github.com/SSSD/sssd/pull/5610#issuecomment-834270467

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: +Pushed

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: -Accepted

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Title: #5610: sudo improvements

Label: -Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5610
Author: pbrezina
Title: #5610: sudo improvements
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5610/head:pr5610
git checkout pr5610