Discussion:
[SSSD] [sssd PR#5600][opened] SSSD Log: log_bad_address_msg_modification
DeepakDas7
2021-04-23 06:08:11 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: SSSD Log: log_bad_address_msg_modification
Action: opened

PR body:
"""
Improve Log Containing Bad Address string

Resolves: https://github.com/SSSD/sssd/issues/5577
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5600/head:pr5600
git checkout pr5600
DeepakDas7
2021-04-25 12:27:17 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: SSSD Log: log_bad_address_msg_modification
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5600/head:pr5600
git checkout pr5600
DeepakDas7
2021-04-25 12:29:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: SSSD Log: log_bad_address_msg_modification
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5600/head:pr5600
git checkout pr5600
ikerexxe
2021-04-28 10:05:32 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Waiting for review
ikerexxe
2021-04-28 10:05:41 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Bugzilla
ikerexxe
2021-04-28 10:05:44 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

ikerexxe commented:
"""
@elkoniu can you take a look at it?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-828330624
DeepakDas7
2021-04-29 14:34:39 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: SSSD Log: log_bad_address_msg_modification
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5600/head:pr5600
git checkout pr5600
elkoniu
2021-05-04 11:40:10 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented:
"""
@ikerexxe Sorry for the delay, have this PR on my review list for this week.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-831876660
elkoniu
2021-05-04 13:08:40 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: -Waiting for review
elkoniu
2021-05-04 13:08:42 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Changes requested
elkoniu
2021-05-04 14:30:32 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented:
"""
I think that when error occurs we should check if we have access to server name and print it always if available rather than making this decision on top of `ret` variable value (`result == EFAULT || result == EIO || result == EPERM)`).
"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-831987182
DeepakDas7
2021-05-09 07:42:33 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: SSSD Log: log_bad_address_msg_modification
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5600/head:pr5600
git checkout pr5600
alexey-tikhonov
2021-05-10 11:01:28 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: SSSD Log: log_bad_address_msg_modification

alexey-tikhonov commented:
"""
It seems those patches break at least one of existing "multihost" tests:
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5600/6/fedora33/multihost-pytest.log

I don't say patches are wrong, but at least tests should be updated as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-836555516
ikerexxe
2021-05-10 12:42:23 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Author: DeepakDas7
Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification
Action: edited

Changed field: title
Original value:
"""
SSSD Log: log_bad_address_msg_modification
"""
elkoniu
2021-05-17 23:24:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5600
Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification

elkoniu commented:
"""
@DeepakDas7 as we discussed on IRC ping me any time this PR will be ready for review :)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-842707488
Loading...