Discussion:
[SSSD] [sssd PR#5565][opened] Tests: Tests if shadow-utils are immune against bugs in 2006:0032
aborah-sudo
2021-04-01 05:22:20 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Author: aborah-sudo
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032
Action: opened

PR body:
"""
Tests if shadow-utils are immune against bugs in 2006:0032
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5565/head:pr5565
git checkout pr5565
aborah-sudo
2021-04-05 12:19:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: +Waiting for review
shridhargadekar
2021-04-08 09:11:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

shridhargadekar commented:
"""
Could you rewrite the 'grep and pipe' part in more pythonic way? 're' module could be used for parsing.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-815595535
aborah-sudo
2021-04-08 09:50:11 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Author: aborah-sudo
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5565/head:pr5565
git checkout pr5565
aborah-sudo
2021-04-08 09:51:26 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

aborah-sudo commented:
"""
Post by shridhargadekar
Could you rewrite the 'grep and pipe' part in more pythonic way? 're' module could be used for parsing.
Fixed
"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-815623344
aborah-sudo
2021-04-09 07:23:53 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Author: aborah-sudo
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5565/head:pr5565
git checkout pr5565
shridhargadekar
2021-04-09 11:04:41 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

shridhargadekar commented:
"""
There are three testcases in original script. Segregate them accordingly. Rest lgtm.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-816604767
shridhargadekar
2021-04-09 11:04:54 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: -Waiting for review
shridhargadekar
2021-04-09 11:04:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: +Accepted
pbrezina
2021-04-12 11:27:06 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: +Ready to push
pbrezina
2021-04-12 11:28:50 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5565

* `master`
* 2319788126e219c0f0c86baa3b7d53ea051570c5 - Tests: Tests if shadow-utils are immune against bugs in 2006:0032

"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-817732625
pbrezina
2021-04-12 11:28:53 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: +Pushed
pbrezina
2021-04-12 11:28:55 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: -Accepted
pbrezina
2021-04-12 11:28:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

Label: -Ready to push
pbrezina
2021-04-12 11:29:02 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Author: aborah-sudo
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5565/head:pr5565
git checkout pr5565
alexey-tikhonov
2021-04-12 13:27:12 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

alexey-tikhonov commented:
"""
Does this test SSSD or shadow-utils...
"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-817810938
alexey-tikhonov
2021-04-12 13:27:21 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5565
Title: #5565: Tests: Tests if shadow-utils are immune against bugs in 2006:0032

alexey-tikhonov commented:
"""
Does this test SSSD or shadow-utils..?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5565#issuecomment-817810938
Loading...