Discussion:
[SSSD] [sssd PR#5663][opened] cache_req: replace FQNs by shortnames
ikerexxe
2021-05-31 13:48:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
Title: #5663: cache_req: replace FQNs by shortnames
Action: opened

PR body:
"""
Replace FQNs by shortnames in cache_req_XYZ_by_name_send() when the FQN
already contains the domain name. This is done to avoid appending again
the domain name to the FQN.

Includes a unit test to check that the FQN to shortname replacement
works correctly.

It also includes an integration test to check that UpdateMemberList()
and GetAll() return the correct users that are members of a group. This
is done by first adding a member to a group and checking that it is
returned correctly. Then, the member is deleted and the interface returns
no members.

Resolves: https://github.com/SSSD/sssd/issues/4255
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663
ikerexxe
2021-05-31 13:49:06 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Bugzilla
ikerexxe
2021-05-31 13:50:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Waiting for review
ikerexxe
2021-06-01 14:45:25 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663
ikerexxe
2021-06-01 15:00:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663
ikerexxe
2021-06-01 15:11:47 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663
ikerexxe
2021-06-02 13:24:04 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663
alexey-tikhonov
2021-06-04 07:53:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Deferred
alexey-tikhonov
2021-06-04 07:54:08 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

alexey-tikhonov commented:
"""
(Postponed a bit. But ready for review.)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-854457162
Loading...