Discussion:
[SSSD] [sssd PR#5529][comment] AD: read trusted domains from local domain as well
sumit-bose
2021-03-30 14:03:01 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

sumit-bose commented:
"""
Is it safe to remove `sdap_domain_remove` call? IIRC there was a reason for it.
Hi,

I guess you are thinking of the domain-disable feature of FreeIPA which is not related to the code here. However, it might be better to keep the removal since otherwise thanks to offline authentication users from a domain removed from the forest would still be able to log in until SSSD's cache is removed. I'll add `Change Requested`.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-810281718
sumit-bose
2021-03-30 14:02:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Changes requested
pbrezina
2021-03-29 12:53:52 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
Is it safe to remove `sdap_domain_remove` call? IIRC there was a reason for it.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-809352974
sumit-bose
2021-04-15 07:22:57 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Author: sumit-bose
Title: #5529: AD: read trusted domains from local domain as well
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5529/head:pr5529
git checkout pr5529
sumit-bose
2021-04-15 07:24:35 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

sumit-bose commented:
"""
Hi,

the latest version does not remove `sdap_domain_remove` anymore.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-820184923
sumit-bose
2021-04-15 07:24:53 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Changes requested
sumit-bose
2021-04-15 07:24:57 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Waiting for review
pbrezina
2021-04-16 10:17:35 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821074678
pbrezina
2021-04-16 10:17:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Ready to push
pbrezina
2021-04-16 10:17:51 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Waiting for review
pbrezina
2021-04-16 10:17:55 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Accepted
pbrezina
2021-04-16 10:23:43 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
Hi Sumit, the first commit has wrong debug message, can you fix that please?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821078020
pbrezina
2021-04-16 10:23:52 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Accepted
pbrezina
2021-04-16 10:23:55 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Changes requested
pbrezina
2021-04-16 10:23:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Ready to push
pbrezina
2021-04-16 10:29:05 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
Hi Sumit, the first commit has wrong commit message, can you fix that please?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821078020
sumit-bose
2021-04-16 11:19:58 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Author: sumit-bose
Title: #5529: AD: read trusted domains from local domain as well
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5529/head:pr5529
git checkout pr5529
sumit-bose
2021-04-16 11:20:30 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

sumit-bose commented:
"""
Post by pbrezina
Hi Sumit, the first commit has wrong commit message, can you fix that please?
ah, sorry, fixed in the latest version.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821106405
pbrezina
2021-04-16 11:23:46 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Ready to push
pbrezina
2021-04-16 11:23:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Accepted
pbrezina
2021-04-16 11:23:51 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Changes requested
pbrezina
2021-04-16 11:24:19 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Ready to push
pbrezina
2021-04-16 11:24:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Ready to push
pbrezina
2021-04-16 11:24:40 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -branch: sssd-1-16
pbrezina
2021-04-16 11:25:08 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5529

* `master`
* 95adf488f94f5968f6cfba9e3bef74c07c02ccff - AD: read trusted domains from local domain as well
* 5d65411f1aa16af929ae2271ee4d3d9101728a67 - sss_domain_info: add not_found_counter

"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821108640
pbrezina
2021-04-16 11:25:11 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: +Pushed
pbrezina
2021-04-16 11:25:14 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Accepted
pbrezina
2021-04-16 11:25:16 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

Label: -Ready to push
pbrezina
2021-04-16 11:25:19 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Author: sumit-bose
Title: #5529: AD: read trusted domains from local domain as well
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5529/head:pr5529
git checkout pr5529
pbrezina
2021-04-16 11:25:22 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5529
Title: #5529: AD: read trusted domains from local domain as well

pbrezina commented:
"""
There was a conflict in 1.16, please open separate PR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5529#issuecomment-821108707
Loading...