Discussion:
[SSSD] [sssd PR#5629][opened] KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation
pbrezina
2021-05-13 10:23:21 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Author: pbrezina
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation
Action: opened

PR body:
"""
sssd-kcm should follow Heimdal's return codes. Heimdal returns `KRB5_FCC_INTERNAL`
for cases where operation code is not known or not implemented. See:

* https://github.com/heimdal/heimdal/blob/master/kcm/protocol.c#L1785
* https://github.com/heimdal/heimdal/blob/master/kcm/protocol.c#L1792

We returned different codes before this patch which makes Kerberos to differentiate
between Heimdal and sssd implementation. This leads to errors like:

* https://github.com/krb5/krb5/pull/1178#issuecomment-838289703

Resolves: https://github.com/SSSD/sssd/issues/5628
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5629/head:pr5629
git checkout pr5629
pbrezina
2021-05-13 10:32:59 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: +Waiting for review
justin-stephenson
2021-05-13 13:51:18 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

justin-stephenson commented:
"""
Looks good to me, though KRB5_CC_NOSUPP seems like a more fitting error code.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5629#issuecomment-840575441
justin-stephenson
2021-05-13 13:51:25 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: -Waiting for review
justin-stephenson
2021-05-13 13:51:28 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: +Accepted
pbrezina
2021-05-14 09:34:04 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: +Ready to push
pbrezina
2021-05-14 09:34:31 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5629

* `master`
* 9b017dbc80cf09b3a2d7e09f771faf70d4538b4f - KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

"""

See the full comment at https://github.com/SSSD/sssd/pull/5629#issuecomment-841132050
pbrezina
2021-05-14 09:34:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: +Pushed
pbrezina
2021-05-14 09:34:38 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: -Accepted
pbrezina
2021-05-14 09:34:40 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation

Label: -Ready to push
pbrezina
2021-05-14 09:34:44 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5629
Author: pbrezina
Title: #5629: KCM: return KRB5_FCC_INTERNAL for unknown or not implemented operation
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5629/head:pr5629
git checkout pr5629

Loading...