[SSSD] [sssd PR#5584][opened] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5584
Author: sumit-bose
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr()
Action: opened

PR body:
"""
When checking if a group returned by an initgroups request is filtered
in the negative cache the domain of the user was used. This does not
work reliable if the user can be a member of groups from multiple
domains.

With this patch th domain the group belongs to is determined and used
while checking the negative cache.

Resolves: https://github.com/SSSD/sssd/issues/5534
(cherry picked from commit c0045cc81bd7c6ec848e93382a2a29fe0d925cd1 with changes)
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5584/head:pr5584
git checkout pr5584

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Author: sumit-bose
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)
Action: edited

Changed field: title
Original value:
"""
negcache: use right domain in nss_protocol_fill_initgr()
"""

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Bugzilla

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

alexey-tikhonov commented:
"""
https://bugzilla.redhat.com/show_bug.cgi?id=1945552
"""

See the full comment at https://github.com/SSSD/sssd/pull/5584#issuecomment-818879623

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

alexey-tikhonov commented:
"""
Hi @sumit-bose ,

thank you for the backport.

Could you please update hash reference in commit description (to 231d1118727b989a4af9911a45a465912fe659d6)?

Otherwise looks good to me.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5584#issuecomment-820564800

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Changes requested

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5584
Author: sumit-bose
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5584/head:pr5584
git checkout pr5584

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

sumit-bose commented:
"""
Hi,

thank you for the careful review, hash is fixed in the latest version.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5584#issuecomment-821322092

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Waiting for review

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: -Changes requested

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

alexey-tikhonov commented:
"""
Thank you. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5584#issuecomment-822275865

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: -Waiting for review

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Accepted

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5584

* `sssd-1-16`
* 48f27f74c9a9d5aebf8d2be941dfb282578ba9ba - negcache: use right domain in nss_protocol_fill_initgr()

"""

See the full comment at https://github.com/SSSD/sssd/pull/5584#issuecomment-823119280

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: -Accepted

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Author: sumit-bose
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5584/head:pr5584
git checkout pr5584

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: -Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5584
Title: #5584: negcache: use right domain in nss_protocol_fill_initgr() (1.16)

Label: +Pushed