Discussion:
[SSSD] [sssd PR#5643][opened] SECRETS: Resolve mkey path correctly
justin-stephenson
2021-05-19 15:05:57 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Author: justin-stephenson
Title: #5643: SECRETS: Resolve mkey path correctly
Action: opened

PR body:
"""
Use the correct master key path for the secrets database,
fixing an issue on upgrade.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5643/head:pr5643
git checkout pr5643
sumit-bose
2021-05-19 15:29:15 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

sumit-bose commented:
"""
Hi,

I tested updates from sssd-2.4.0 and kcm is now working as expected, so ACK with respect to functionality.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5643#issuecomment-844216166
pbrezina
2021-05-19 15:37:38 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

pbrezina commented:
"""
Code-wise ack as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5643#issuecomment-844223119
pbrezina
2021-05-19 15:53:46 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

pbrezina commented:
"""
@justin-stephenson Tests fails:

```
/shared/sssd/src/tests/cmocka/test_kcm_renewals.c: In function 'test_kcm_renewals_tgt':
/shared/sssd/src/tests/cmocka/test_kcm_renewals.c:202:34: warning: passing argument 4 of 'sss_sec_init_with_path' from incompatible pointer type [-Wincompatible-pointer-types]
202 | &secdb->sctx);
| ^~~~~~~~~~~~
| |
| struct sss_sec_ctx **
In file included from /shared/sssd/src/responder/kcm/kcmsrv_ccache_secdb.c:28,
from /shared/sssd/src/tests/cmocka/test_kcm_renewals.c:35:
/shared/sssd/src/util/secrets/secrets.h:86:44: note: expected 'const char *' but argument is of type 'struct sss_sec_ctx **'
86 | const char *mkeypath,
| ~~~~~~~~~~~~^~~~~~~~
/shared/sssd/src/tests/cmocka/test_kcm_renewals.c:201:11: error: too few arguments to function 'sss_sec_init_with_path'
201 | ret = sss_sec_init_with_path(test_ctx->ccdb, NULL, TEST_DB_FULL_PATH,
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from /shared/sssd/src/responder/kcm/kcmsrv_ccache_secdb.c:28,
from /shared/sssd/src/tests/cmocka/test_kcm_renewals.c:35:
/shared/sssd/src/util/secrets/secrets.h:83:9: note: declared here
83 | errno_t sss_sec_init_with_path(TALLOC_CTX *mem_ctx,
| ^~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:40133: src/tests/cmocka/test_kcm_renewals-test_kcm_renewals.o] Error 1
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/5643#issuecomment-844237509
justin-stephenson
2021-05-19 15:59:06 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Author: justin-stephenson
Title: #5643: SECRETS: Resolve mkey path correctly
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5643/head:pr5643
git checkout pr5643
pbrezina
2021-05-19 16:39:21 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

pbrezina commented:
"""
Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5643#issuecomment-844276325
pbrezina
2021-05-19 17:22:47 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

Label: +Ready to push
pbrezina
2021-05-19 17:22:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

Label: +Accepted
pbrezina
2021-05-19 17:24:19 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5643

* `master`
* dbde4e692e34d3ff8233ac17a5eae5a062637e48 - SECRETS: Resolve mkey path correctly

"""

See the full comment at https://github.com/SSSD/sssd/pull/5643#issuecomment-844311994
pbrezina
2021-05-19 17:24:22 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

Label: +Pushed
pbrezina
2021-05-19 17:24:26 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

Label: -Accepted
pbrezina
2021-05-19 17:24:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Title: #5643: SECRETS: Resolve mkey path correctly

Label: -Ready to push
pbrezina
2021-05-19 17:24:31 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5643
Author: justin-stephenson
Title: #5643: SECRETS: Resolve mkey path correctly
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5643/head:pr5643
git checkout pr5643

Loading...