Discussion:
[SSSD] [sssd PR#5572][opened] Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
yrro
2021-04-07 14:01:45 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: opened

PR body:
"""
Fixes #5568
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
alexey-tikhonov
2021-04-07 15:16:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Waiting for review
yrro
2021-04-07 17:26:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
yrro
2021-04-07 17:35:33 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
alexey-tikhonov
2021-04-07 18:38:42 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

alexey-tikhonov commented:
"""
Thank you for the patches. In general looks good to me.

Could you please add `Resolves: https://github.com/SSSD/sssd/issues/5568` to the commit message of first patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5572#issuecomment-815136851
yrro
2021-04-07 18:43:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
yrro
2021-04-07 19:03:08 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
yrro
2021-04-07 19:07:08 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
yrro
2021-04-08 18:09:55 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
yrro
2021-04-09 08:41:43 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572
alexey-tikhonov
2021-04-09 08:49:25 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

alexey-tikhonov commented:
"""
Thank you, ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5572#issuecomment-816528955
alexey-tikhonov
2021-04-09 08:49:30 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Accepted
alexey-tikhonov
2021-04-09 08:49:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Bugzilla
alexey-tikhonov
2021-04-09 08:49:37 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: -Accepted
alexey-tikhonov
2021-04-09 08:49:41 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: -Bugzilla
alexey-tikhonov
2021-04-09 17:42:15 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Accepted
alexey-tikhonov
2021-04-09 17:42:18 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: -Waiting for review
pbrezina
2021-04-12 11:26:42 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Ready to push
pbrezina
2021-04-12 11:28:22 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5572

* `master`
* b87619f9a917d6ed9ecdb5360c4bf242dce8e372 - responder/common/responder_packet: allow packets of max size
* 5c9fa75bd0ffa02e31cbbf19ee68134ed384229a - responder/common/responder_packet: remove some unnecessary checks before growing packet
* 37d331774385b2b871ba76fcdef6ceafd776efce - responder/common/responder_packet: further increase packet size for SSS_GSSAPI_SEC_CTX
* 63f318f73c933dc2cb08cad2f911a52d2281c45b - responder/common/responder_packet: add debug logging to assist with errors caused by overlarge packets
* c6a76283580c25ff78b36b8b23efdabbdb3a2cc1 - responder/common/responder_packet: reduce duplication of code that handles larger-than-normal packets
* b6efe6b119b0c11314a324e8a2cf96fb74a9c983 - responder/common/responder_packet: handle large service tickets

"""

See the full comment at https://github.com/SSSD/sssd/pull/5572#issuecomment-817732340
pbrezina
2021-04-12 11:28:25 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: +Pushed
pbrezina
2021-04-12 11:28:28 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: -Accepted
pbrezina
2021-04-12 11:28:30 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets

Label: -Ready to push
pbrezina
2021-04-12 11:28:33 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5572
Author: yrro
Title: #5572: Handle large service tickets in SSS_GSSAPI_SEC_CTX packets
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5572/head:pr5572
git checkout pr5572

Loading...