[SSSD] [sssd PR#5602][opened] spec: Remove ldconfig scripts

[ikerexxe]

URL: https://github.com/SSSD/sssd/pull/5602
Author: ikerexxe
Title: #5602: spec: Remove ldconfig scripts
Action: opened

PR body:
"""
According to
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact
spec files that target Fedora 28+ don't require the use of ldconfig
scriptlets. So, I'm removing them from the spec file.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5602/head:pr5602
git checkout pr5602

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

alexey-tikhonov commented:
"""
https://docs.fedoraproject.org/ms/fedora/f28/release-notes/developers/Development_Tools/#sect-ldconfig-scriptlets
-- don't we need 'file triggers" instead? Like:
```
%filetriggerin -- /usr/lib /lib
/usr/sbin/ldconfig
```
(https://rpm.org/user_doc/file_triggers.html)

"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827042082

[ikerexxe]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

ikerexxe commented:
"""
I'm not sure because the Fedora Change page doesn't specify such a requirement. I've sent an email to the owners of the change and set you in CC.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827417382

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

alexey-tikhonov commented:
"""
It was explained that file triggers are defined in glibc package.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827638942

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Label: +Accepted

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

alexey-tikhonov commented:
"""
It was explained that file triggers are defined in glibc package.
ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827638942

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

alexey-tikhonov commented:
"""

It's weird seeing a spec file with no file lists

Why "no file lists"?

https://github.com/SSSD/sssd/blob/128ea9fd09db8a6c16f030a9b5d56aba359bf6f0/contrib/sssd.spec.in#L645
https://github.com/SSSD/sssd/blob/128ea9fd09db8a6c16f030a9b5d56aba359bf6f0/contrib/sssd.spec.in#L754

etc...
"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827713187

[Conan-Kudo]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Conan-Kudo commented:
"""
Ah, I missed that! 😅
"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-827713913

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Label: +Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Label: +Pushed

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5602

* `master`
* 9854ade1642f12e1715f156919d43746664c7800 - spec: Remove ldconfig scripts

"""

See the full comment at https://github.com/SSSD/sssd/pull/5602#issuecomment-829104824

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Label: -Ready to push

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Title: #5602: spec: Remove ldconfig scripts

Label: -Accepted

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5602
Author: ikerexxe
Title: #5602: spec: Remove ldconfig scripts
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5602/head:pr5602
git checkout pr5602