Discussion:
[SSSD] [sssd PR#5605][opened] libwbclient-sssd: removed
alexey-tikhonov
2021-04-26 17:54:40 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Author: alexey-tikhonov
Title: #5605: libwbclient-sssd: removed
Action: opened

PR body:
"""
:relnote: SSSD's implementation of 'libwbclient' was removed
as incompatible with modern version of Samba.

Resolves: https://github.com/SSSD/sssd/issues/5459
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5605/head:pr5605
git checkout pr5605
alexey-tikhonov
2021-04-26 17:57:05 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

alexey-tikhonov commented:
"""
@sgoveas, please take a look at: https://github.com/SSSD/sssd/pull/5605/commits/f34257cfd0e2f86edcbc84e02fd4737e3814419c?file-filters%5B%5D=.py#diff-e4ef93636bd6c6a155e832b3ce4a90402ccfc0f9d92e08448a2d7804f63d8593
-- I removed one test from `multihost/ad`
"""

See the full comment at https://github.com/SSSD/sssd/pull/5605#issuecomment-827035855
sgoveas
2021-04-28 10:06:48 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

sgoveas commented:
"""
ACK for removal of test
"""

See the full comment at https://github.com/SSSD/sssd/pull/5605#issuecomment-828331351
sumit-bose
2021-04-28 11:20:34 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

sumit-bose commented:
"""
Post by sgoveas
ACK for removal of test
Thanks for the feedback.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5605#issuecomment-828374037
sumit-bose
2021-04-28 11:20:44 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

Label: +Accepted
pbrezina
2021-04-29 10:03:16 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

Label: +Ready to push
pbrezina
2021-04-29 10:05:27 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5605

* `master`
* 846296d17de07c9ad99484b32e21d82a619926b7 - libwbclient-sssd: removed

"""

See the full comment at https://github.com/SSSD/sssd/pull/5605#issuecomment-829104624
pbrezina
2021-04-29 10:05:30 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

Label: +Pushed
pbrezina
2021-04-29 10:05:32 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

Label: -Ready to push
pbrezina
2021-04-29 10:05:36 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Title: #5605: libwbclient-sssd: removed

Label: -Accepted
pbrezina
2021-04-29 10:05:38 UTC
Permalink
URL: https://github.com/SSSD/sssd/pull/5605
Author: alexey-tikhonov
Title: #5605: libwbclient-sssd: removed
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5605/head:pr5605
git checkout pr5605

Loading...